Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL swapping for marketplace based on environment #8418

Merged

Conversation

Abhi1992002
Copy link
Contributor

Fixes #8371

These changes are needed to automatically switch between local and production marketplace URLs, ensuring the app connects to the correct environment (dev or prod) without manual intervention.

Changes 🏗️

  1. Swaps marketplace URL based on APP_ENV (dev or prod).
  2. Ensures correct URL is used for local or production environments.

@Abhi1992002 Abhi1992002 requested a review from a team as a code owner October 24, 2024 05:43
@Abhi1992002 Abhi1992002 requested review from Torantulino and aarushik93 and removed request for a team October 24, 2024 05:43
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Oct 24, 2024
Copy link

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

8371 - Fully compliant

Fully compliant requirements:

  • Allow swapping of marketplace URL based on dev or prod environment
  • Use local marketplace for dev environment
  • Use production marketplace for prod environment
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Hardcoded URLs:
The PR introduces hardcoded URLs for both production and development environments. While this doesn't directly expose sensitive information, it's generally considered a security best practice to avoid hardcoding URLs, especially production ones, directly in the source code. Consider using environment variables or a secure configuration management system to store and retrieve these URLs.

⚡ Recommended focus areas for review

Hardcoded URLs
The production and local marketplace URLs are hardcoded in the component. Consider moving these to environment variables or a configuration file for better maintainability and security.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 8b4f9ed
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/674da0d21323ac0008a6f348
😎 Deploy Preview https://deploy-preview-8418--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aarushik93 aarushik93 changed the base branch from master to dev October 31, 2024 17:56
@github-actions github-actions bot added size/m and removed size/s labels Nov 1, 2024
@Abhi1992002 Abhi1992002 force-pushed the feature/env-based-marketplace branch from 51dcbe2 to 8cd91c9 Compare November 9, 2024 04:20
@aarushik93 aarushik93 enabled auto-merge December 2, 2024 11:57
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 8b4f9ed
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/674da0d2d296f00008dc8dd3

@aarushik93 aarushik93 added this pull request to the merge queue Dec 2, 2024
Merged via the queue into Significant-Gravitas:dev with commit dce9bdd Dec 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Market] Allow use of dev marketplace in dev project
3 participants